You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@0xdevcollins
Review for the PR:
The stream works which is good
The placement for the starting a stream isnt implemented on the page it should, the starting of the stream, pasting the streamkey and id should be on the 3rd party streaming app, the generation of the streamingid and key shoould be stored in the users database (encrypted) and displayed in the settings/stream-preferences page
The preview for the stream cannot be on a seperate tab and the playback id should not display or even copied and pasted directly by the user, should be integrated for that stream into the preview (the page for this is the dashboard/stream-manager)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress
Description
Closes #227
Changes proposed
What were you told to do?
What did you do?
Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots/Videos